Windows build errors : static link wait_set_subscriber_library #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya <[email protected]>
|
Windows CI : |
sloretz
requested changes
Aug 25, 2022
| @@ -36,7 +36,7 @@ ament_target_dependencies(subscriber_not_composable rclcpp std_msgs) | |||
| add_executable(subscriber_content_filtering content_filtering.cpp) | |||
| ament_target_dependencies(subscriber_content_filtering rclcpp std_msgs) | |||
|
|
|||
| add_library(wait_set_subscriber_library SHARED | |||
There was a problem hiding this comment.
rclcpp_components_register_node below is registering this as a plugin. This can only be used with shared libraries. I don't think the problem in #344 is this library being a shared library; instead, I think there's a problem is in whatever is expecting it not to be one.
|
This doesn't look the right fix for this issue, so closing this out for now. |
|
As a beginner in ROS2, I wonder if this problem has been solved yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem mentioned here : #344
Windows builds are not able to find
wait_set_subscriber_library.libSigned-off-by: Aditya [email protected]